Fix #to_rack to handle non-array response bodies. #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using #to_rack with a Rails endpoint, such as:
stub_request(:any, %r{api.example.com/.*}).to_rack(Rails.application)
...you receive the following error:
NoMethodError: undefined method `join' for #<ActionDispatch::Response:0x007ffd06e6f540>
Turns out ActionDispatch::Response is in the right. A Rack response body
is only required to implement #each, not #join.
This patch fixes #to_rack to build the body using the #each method.
|
Thank you for the patch! |
bblimke
added a commit
that referenced
this pull request
Jan 22, 2012
Fix #to_rack to handle non-array response bodies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
#to_rackwith a Rails endpoint, such as:...you receive the following error:
Turns out
ActionDispatch::Responseis in the right. A Rack response bodyis only required to implement
#each, not#join.This patch fixes
#to_rackto build the body using the#eachmethod.